linux-kernel - Re: Bug in SCSI async probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243352063.2815.34.camel@localhost.localdomain>
Date:	Tue, 26 May 2009 10:34:23 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Arjan van de Ven <arjan@...ux.intel.com>,
	SCSI development list <linux-scsi@...r.kernel.org>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: Bug in SCSI async probing

On Tue, 2009-05-26 at 11:22 -0400, Alan Stern wrote:
> James & Arjan:
> 
> Am I missing something here?  It looks like
> 
> 	fastboot: make scsi probes asynchronous
> 
> has introduced a bug in the sd probing code.  AFAICT, there is now
> nothing to prevent do_scan_async() from returning before
> sd_probe_async() has run.

True, but this isn't really a problem.

> Doesn't this mean that there's nothing to prevent sd_remove() from 
> being called and trying to unregister the disk _before_ 
> sd_probe_async() has managed to register it?

Yes, we've been discussing this ... most of the removal functions now
need async_synchronize calls to mitigate this type of race.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/