linux-kernel - Re: [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 May 2009 13:30:53 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	vapier@...too.org, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH] drivers/char/rtc: disable legacy RTC driver on Blackfin
 systems

On Tue, 26 May 2009 06:25:02 -0400
Christoph Hellwig <hch@...radead.org> wrote:

> On Tue, May 26, 2009 at 06:10:33AM -0400, Mike Frysinger wrote:
> >  	tristate "Enhanced Real Time Clock Support (legacy PC RTC driver)"
> >  	depends on !PPC && !PARISC && !IA64 && !M68K && !SPARC && !FRV \
> > -			&& !ARM && !SUPERH && !S390 && !AVR32
> > +			&& !ARM && !SUPERH && !S390 && !AVR32 && !BLACKFIN
> 
> Maybe it's better to have a positive dependency for those that actually
> support it these days?

yeah, we do this rather a lot and it's pretty stupid.

>  Based on the above list that would be:
> 
> 	depends on ALPHA || CRIS || H8300 || M32R || MICROBLAZE ||
> 		   MIPS || MN10300 || SH || X86 || XTENSA
> 
> and I would not be surprised if some of the above don't actually support
> it either..

It would be better to make this driver depend on simply CONFIG_WANT_RTC
or similar and then select CONFIG_WANT_RTC in the relevant
arch/foo/Kconfig files.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/