linux-kernel - Re: [PATCH 3/3] ftrace: add tracepoint for itimer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0905262344160.1762@localhost.localdomain>
Date:	Tue, 26 May 2009 23:50:46 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Xiao Guangrong <xiaoguangrong@...fujitsu.com>
cc:	mingo@...e.hu, LKML <linux-kernel@...r.kernel.org>,
	Zhaolei <zhaolei@...fujitsu.com>, kosaki.motohiro@...fujitsu.com,
	Steven Rostedt <rostedt@...dmis.org>, fweisbec@...il.com
Subject: Re: [PATCH 3/3] ftrace: add tracepoint for itimer

On Fri, 22 May 2009, Xiao Guangrong wrote:
> +TRACE_EVENT(itimer_start,
> +
> +	TP_PROTO(int which, struct itimerval *value),
> +
> +	TP_ARGS(which, value),
> +
> +	TP_STRUCT__entry(
> +		__field(	int,			which		)
> +		__field(	unsigned long long,	it_value	)
> +		__field(	unsigned long long,	it_interval	)
> +		__string(	comm,   		current->comm   )
> +	),
> +
> +	TP_fast_assign(
> +		__entry->which		= which;
> +		__entry->it_value	= (which == ITIMER_REAL ?
> +			ktime_to_ns(timeval_to_ktime(value->it_value)) :
> +			timeval_to_cputime(&value->it_value));
> +		 __entry->it_interval 	= (which == ITIMER_REAL ?
> +			ktime_to_ns(timeval_to_ktime(value->it_interval)) :
> +			timeval_to_cputime(&value->it_interval));
> +		__assign_str(comm, current->comm);
> +	),

  Again, conversion of raw values needs to be done when we analyse the
  trace and not in the fast path.

....

> +		} else{
  
  } else {

  please
>  			tsk->signal->it_real_incr.tv64 = 0;
> +			trace_itimer_cancel(ITIMER_REAL);
> +		}
>  
>  		spin_unlock_irq(&tsk->sighand->siglock);
>  		break;
> @@ -186,7 +191,10 @@ again:
>  						   jiffies_to_cputime(1));
>  			set_process_cpu_timer(tsk, CPUCLOCK_VIRT,
>  					      &nval, &cval);
> -		}
> +			trace_itimer_start(ITIMER_VIRTUAL, value);
> +		}else

  Please run your patches through checkpatch.pl

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/