linux-kernel - Re: [PATCH 001/001] gpio: AMD CS5535/CS5536 GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090526151621.a7446c60.akpm@linux-foundation.org>
Date:	Tue, 26 May 2009 15:16:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Tobias_Mueller@...m.info
Cc:	linux-kernel@...r.kernel.org, David Brownell <david-b@...bell.net>,
	Jordan Crouse <jordan@...micpenguin.net>,
	Ben Gardner <gardner.ben@...il.com>
Subject: Re: [PATCH 001/001] gpio: AMD CS5535/CS5536 GPIO driver

On Sat, 23 May 2009 13:53:58 +0200
Tobias M__ller <Tobias_Mueller@...m.info> wrote:

> From: Tobias Mueller <Tobias_Mueller@...m.info>
> 
> A GPIO driver for AMD Geode Companion Device CS5535/CS5536
> using the GPIO framework as a replacement for old cs5535-gpio driver.

It looks reasonsable from a quick scan.

The patch was somewhat wordwrapped by your email client.

The patch generates a large number of warnings when checked with
scripts/checkpatch.pl.  Please take a look at that and permanently
incorporate checkpatch into your patch generation tools.

Please cc the following individuals on future versions of this patch:

David Brownell <david-b@...bell.net>
Jordan Crouse <jordan@...micpenguin.net>
Ben Gardner <gardner.ben@...il.com>

> index edb0253..0b7ef6f 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -67,6 +67,14 @@ config GPIO_SYSFS
> 
>  comment "Memory mapped GPIO expanders:"
> 
> +config GPIO_CS5535
> +	tristate "AMD CS5535/CS5536 (Geode Companion Device)"
> +	depends on !CONFIG_CS5535_GPIO && X86 && EXPERIMENTAL
> +	default N
> +	help
> +	  Say yes here to support GPIO pins of AMD CS5535/CS5536
> +          (Geode Companion Device)

We'll need to discuss the migration plan - we don't want to maintain
two drivers for the same thing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/