linux-kernel - Re: [PATCH 03/13] scsi: unify allocation of scsi command and sense buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090526132914W.fujita.tomonori@lab.ntt.co.jp>
Date:	Tue, 26 May 2009 13:36:42 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	rdreier@...co.com
Cc:	bharrosh@...asas.com, jens.axboe@...cle.com,
	fujita.tomonori@....ntt.co.jp, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, chris.mason@...cle.com,
	david@...morbit.com, hch@...radead.org, akpm@...ux-foundation.org,
	jack@...e.cz, yanmin_zhang@...ux.intel.com
Subject: Re: [PATCH 03/13] scsi: unify allocation of scsi command and sense
 buffer

On Mon, 25 May 2009 18:45:25 -0700
Roland Dreier <rdreier@...co.com> wrote:

>  > Ideally there should be a MACRO that is defined to WORD_SIZE on cache-coherent
>  > ARCHs and to SMP_CACHE_BYTES on none-cache-coherent systems and use that size
>  > at the __align() attribute. (So only stupid ARCHES get hurt)
> 
> this seems to come up repeatedly -- I had a proposal a _long_ time ago
> that never quite got merged, cf http://lwn.net/Articles/2265/ and
> http://lwn.net/Articles/2269/ -- from 2002 (!?).  The idea is to go a

Yeah, I think that Benjamin did last time:

http://www.mail-archive.com/linux-scsi@vger.kernel.org/msg12632.html

IIRC, James didn't like it so I wrote the current code. I didn't see
any big performance difference with scsi_debug:

http://marc.info/?l=linux-scsi&m=120038907123706&w=2

Jens, you see the performance difference due to this unification?


Personally, I don't fancy __cached_alignment__ annotation much. I
prefer to leave it behind a memory allocator.


> step further and create a __dma_buffer annotation for structure members.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/