linux-kernel - Re: [Patch 4/4] module: trim exception table in module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1CAF44.7000002@redhat.com>
Date:	Wed, 27 May 2009 11:11:00 +0800
From:	Amerigo Wang <amwang@...hat.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	linux-alpha@...r.kernel.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, jdike@...toit.com, mingo@...e.hu,
	sparclinux@...r.kernel.org, linux-ia64@...r.kernel.org
Subject: Re: [Patch 4/4] module: trim exception table in module_free()

Rusty Russell wrote:
> On Tue, 26 May 2009 06:05:39 pm Amerigo Wang wrote:
>   
>>  void module_free(struct module *mod, void *module_region)
>>  {
>>  	vfree(module_region);
>> -	/* FIXME: If module_region == mod->init_region, trim exception
>> -	   table entries. */
>> +	if (module_region == mod->module_init)
>> +		mod->num_exentries = 0;
>>  }
>>     
>
> Hi Amerigo,
>
>    This looks wrong.  The extable covers both init and core exception entries.   
> We want to remove the ones in the module_init section.  The good news is that 
> it's sorted, so they're either at the start or the end (except sparc 32).
>   

Hi, Rusty.

Yes? The extable of a module is in '__ex_table' section, and during the 
section transfer, one
section will be either in module_init or module_core, so its entries are 
only in one of them,
not both, right?

Thank you.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/