linux-kernel - Re: [PATCH 19/31] x86: MCE: Default to panic timeout for machine checks v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090527072445.GS846@one.firstfloor.org>
Date:	Wed, 27 May 2009 09:24:45 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	hpa@...or.com, x86@...nel.org, Andi Kleen <ak@...ux.intel.com>
Subject: Re: [PATCH 19/31] x86: MCE: Default to panic timeout for machine checks v2

On Wed, May 27, 2009 at 01:31:07PM +0900, Hidetoshi Seto wrote:
> I suppose the original intention is overwrite the panic_timeout 0 to 30.

Yes. 

> > @@ -1100,6 +1105,8 @@ static void mce_cpu_quirks(struct cpuinfo_x86 *c)
> >  	}
> >  	if (monarch_timeout < 0)
> >  		monarch_timeout = 0;
> > +	if (mce_bootlog != 0)
> > +		mce_panic_timeout = 30;
> >  }
> >  
> >  static void __cpuinit mce_ancient_init(struct cpuinfo_x86 *c)
> 
> It seems it doesn't work.

Okay fair point. I applied your earlier review suggestion literally yes
that was not correct. I changed it in my patchkit to handle the 0 case too.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/