linux-kernel - Re: [PATCH] cgroups: handle failure of cgroup_populate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090527103404.81d3c1a4.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 27 May 2009 10:34:04 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	Paul Menage <menage@...gle.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux Containers <containers@...ts.linux-foundation.org>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>
Subject: Re: [PATCH] cgroups: handle failure of cgroup_populate_dir() at 
 mount/remount

On Wed, 27 May 2009 09:07:31 +0800
Li Zefan <lizf@...fujitsu.com> wrote:

> Paul Menage wrote:
> > On Fri, May 22, 2009 at 1:25 AM, KAMEZAWA Hiroyuki
> > <kamezawa.hiroyu@...fujitsu.com> wrote:
> >> Hm, shouldn't we allow "noprefix" to be effective only agaisnt cpuset ?
> >> I think it's just for backward-compatibility of cpuset.
> >> (I don't like the option at all.)
> > 
> > Yes, exposing the "noprefix" option externally was one of the mistakes
> > I made when developing cgroups.
> > 
> > It seems to me really unlikely that anyone is using "noprefix" for
> 
> And "noprefix" is not documented in cgroups.txt, so I guess not
> many people know this option. Even libcgroup doesn't handle it.
> 
> > anything other than implicitly when mounting the "cpuset" filesystem.
> > So I'd be inclined to just forbid it if we're mounting more than just
> > the cpuset subsystem. A bit of a nasty abstraction violation, but it
> > makes more sense overall. The only problem is that someone *might* be
> > using it - do we have any way to determine how, and how big do they
> > have to be before we care?
> > 
> 
> I think we can never know..

How about this method ?

 - add "noprefix" to "to-be-removed" list.
 - add "WARNING: noprefix option will be removed in 2.6.32 (or 2.6.31)" now
 - remove "noprefix" in 2.6.31-rc or later

Thanks,
-Kame





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/