linux-kernel - Re: [PATCH] kvm: fix coalesced

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090527202932.GI20823@sequoia.sous-sol.org>
Date:	Wed, 27 May 2009 13:29:32 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Gregory Haskins <ghaskins@...ell.com>
Cc:	avi@...hat.com, kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kvm: fix coalesced_mmio leak on shutdown

* Gregory Haskins (ghaskins@...ell.com) wrote:
> It would appear that we are invoking kfree() on the wrong pointer in the
> destructor for the coalesced_mmio device.  This would result in a potential
> leak during shutdown.

Happens to work and not leak:

struct kvm_coalesced_mmio_dev { 
        struct kvm_io_device dev;
        struct kvm *kvm;
        int nb_zones;
        struct kvm_coalesced_mmio_zone zone[KVM_COALESCED_MMIO_ZONE_MAX];
};

> Signed-off-by: Gregory Haskins <ghaskins@...ell.com>
> ---
> 
>  virt/kvm/coalesced_mmio.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/virt/kvm/coalesced_mmio.c b/virt/kvm/coalesced_mmio.c
> index 5ae620d..03ea280 100644
> --- a/virt/kvm/coalesced_mmio.c
> +++ b/virt/kvm/coalesced_mmio.c
> @@ -80,7 +80,10 @@ static void coalesced_mmio_write(struct kvm_io_device *this,
>  
>  static void coalesced_mmio_destructor(struct kvm_io_device *this)
>  {
> -	kfree(this);
> +	struct kvm_coalesced_mmio_dev *dev =
> +		(struct kvm_coalesced_mmio_dev *)this->private;

I think container_of() makes more sense here.

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/