linux-kernel - Re: [PATCH 1/3] clean up functions related to pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090527133845.a26df9cb.akpm@linux-foundation.org>
Date:	Wed, 27 May 2009 13:38:45 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Minchan Kim <minchan.kim@...il.com>
Cc:	minchan.kim@...il.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, mel@....ul.ie, kosaki.motohiro@...fujitsu.com,
	riel@...hat.com, hannes@...xchg.org, y-goto@...fujitsu.com
Subject: Re: [PATCH 1/3]  clean up functions related to pages_min V2

On Wed, 27 May 2009 20:29:55 +0900
Minchan Kim <minchan.kim@...il.com> wrote:

> This patch change names of two functions. so It doesn't affect behavior. 
> Now, setup_per_zone_pages_min changes low, high of zone as well as min.
> So, a better name might have been setup_per_zone_wmarks.That's because
> Mel changed zone->pages_[hig/low/min] to zone->watermark array.(434b5394fd85c212619306cda6bf087be737b35a)
> 

When quoting changeset IDs, please do it in the form

  0594ad1a66381076f0fa06f5605ea5023f600586 ("mfd/pcf50633-gpio.c: add MODULE_LICENSE")

There's a good reason for this, but I forget what it is.  Perhaps so
that the same commit can be located if it has a different hash?  I
expect that commits get a different hash when backported into -stable,
for example.

I spend my life making changes like that to changelogs, but when I went
to fix up your 434b5394fd85c212619306cda6bf087be737b35a, I was unable
to locate any commit which has that hash.

<searches for a while>

Ah, you're referring to a -mmotm patch.  The hashes in -mmotm aren't
useful because the tree gets regenerated each time.  So let's refer to
that patch via just its title, "page allocator: replace the
watermark-related union in struct zone with a watermark[] array".

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/