linux-kernel - Re: [PATCH] ftrace: Don't convert function's local variable name in macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090527231435.GC20509@elte.hu>
Date:	Thu, 28 May 2009 01:14:35 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Zhaolei <zhaolei@...fujitsu.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ftrace: Don't convert function's local variable name
	in macro


* Frederic Weisbecker <fweisbec@...il.com> wrote:

> On Wed, May 27, 2009 at 09:36:02PM +0800, Zhaolei wrote:
> > "call" is a argument of macro, but it is also used as a local variable name of
> > function in macro.
> > We should keep this local variable name static although it haven't cause
> > problem now.
> > 
> > [ Impact: cleanup, no functionality changed ]
> 
> 
> I'm applying it.
> 
> Note, I'm also changing the impact line. This is more than a
> cleanup, it's a real fix to prevent from possible CPP side effects.
> 
> So I'll put instead:
> 
> [ Impact: prevent from accidental CPP substitution ]

I suspect it should be something like:

  [ Impact: robustify macro ]

or so.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/