linux-kernel - Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090528104823.0a551ecb@mjolnir.ossman.eu>
Date:	Thu, 28 May 2009 10:48:23 +0200
From:	Pierre Ossman <pierre@...man.eu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	dsaxena@...xity.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path

On Thu, 28 May 2009 01:36:29 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Fri, 22 May 2009 13:51:50 +0200 Pierre Ossman <pierre@...man.eu> wrote:
> 
> > 
> > Reading through that report, I don't believe you properly worked around
> > the bug. You only avoid bug 1339, but that's only mildly related.
> > 
> > What this workaround does is to make sure that MMC_UNSAFE_RESUME
> > actually works. But if you change cards during suspend, the VFS bug
> > should reappear and you'll corrupt the partition table.
> 
> What do you think the VFS did wrong here?
> 

Might be the block layer as well. Somehow requests associated with an
old block device end up on the queue of a new block device. I don't
see how this can happen given Linux' device model, but somehow it does.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)