linux-kernel - IFF_LOWER_UP does not fit in ifr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <89A39FC0957640879F8975880836CF91@edgeware.tv>
Date:	Thu, 28 May 2009 14:59:05 +0200
From:	"Fredrik Arnerup" <fredrik.arnerup@...eware.tv>
To:	<linux-kernel@...r.kernel.org>
Subject: IFF_LOWER_UP does not fit in ifr_flags

Documentation/networking/operstates.txt (and netdevice(7)) claims that
the flags IFF_LOWER_UP, IFF_DORMANT and IFF_ECHO can be read from user space
using ioctl() with SIOCGIFFLAGS. Looking in include/linux/if.h however,
the flags are returned in a struct ifreq in the field ifr_flags which
is declared as a short, while the flags are defined as:

#define IFF_LOWER_UP    0x10000         /* driver signals L1 up         */
#define IFF_DORMANT     0x20000         /* driver signals dormant       */
#define IFF_ECHO        0x40000         /* echo sent packets            */

Those aren't shorts, are they? In net/core/dev.c dev_get_flags() returns
an unsigned which is assigned to ifr_flags directly.

Looked at linux/kernel/git/stable/linux-2.6.29.y.git.
CC me please.

/Fredrik Arnerup
fredrik.arnerup@...eware.tv

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/