linux-kernel - Re: [PATCH] tracing/lockdep: report the time waited for a lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090528143907.GB6018@nowhere>
Date:	Thu, 28 May 2009 16:39:09 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/lockdep: report the time waited for a lock

On Thu, May 28, 2009 at 04:34:43PM +0200, Peter Zijlstra wrote:
> On Thu, 2009-05-28 at 10:32 -0400, Steven Rostedt wrote:
> 
> > > +	TP_STRUCT__entry(
> > > +		__field(const char *, name)
> > > +		__field(unsigned long, wait_usec)
> > > +		__field(unsigned long, wait_nsec_rem)
> > > +	),
> > > +	TP_fast_assign(
> > > +		__entry->name = lock->name;
> > > +		__entry->wait_nsec_rem = do_div(waittime, NSEC_PER_USEC);
> > 
> > I know this is already accepted, but can you move the do_div into the 
> > print section.
> 
> please do. Just fold those wait_* fields into a single u64 nsec one.


Indeed, I'll fix it. Thanks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/