linux-kernel - Re: [PATCH 01/20] sysfs: Implement sysfs_rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090528003721.GB2720@suse.de>
Date:	Wed, 27 May 2009 17:37:21 -0700
From:	Greg KH <gregkh@...e.de>
To:	Kay Sievers <kay.sievers@...y.org>
Cc:	Greg KH <greg@...ah.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	Benjamin Thery <benjamin.thery@...l.net>,
	Daniel Lezcano <dlezcano@...ibm.com>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link

On Thu, May 28, 2009 at 02:30:15AM +0200, Kay Sievers wrote:
> On Thu, May 28, 2009 at 02:14, Greg KH <greg@...ah.com> wrote:
> >
> > So, there's been a lot of talk in this thread.
> >
> > Eric, do you have an updated set of patches for me to try out?
> 
> I think we should get a version of the patch in that removes all files
> in a directory on cleanup, but warn if a subdirectory is still there.
> James has a patch to fix the one issue we've seen so far with existing
> child directories.
> 
> After that, we should work on fixing the users that leave files
> behind, and can possibly stop cleaning up files, if we want to.

That would be good.

But note that we always "allowed" such things to happen, so odds are
there are lots of places in the kernel that took advantage of this.  If
we make it a rule, people will complain.

> > Or are there still problems, like the "fry the ext3 boot partition" that
> > Kay found?
> 
> That is unrelated to Eric's patches, They just added the dump, which I
> tried to trigger. It's not entirely clear what caused the filesytem
> damage, but I was definitely able to reproduce the unclean shutdown
> without any of Eric's sysfs patches.

Ok.

But I think Eric had some updates to some of the patches along the way,
so a whole new respin would be good to ensure I get the correct ones.

Eric?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/