linux-kernel - Re: [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090528031907.E179FFC2BD@magilla.sf.frob.com>
Date:	Wed, 27 May 2009 20:19:07 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 7/X] ptrace: mv task->parent ptrace_task->pt_tracer

If you're going to zero out fields in a corner case, I think you should
zero si_code too so it's consistent with what collect_signal() produces
when a signal is posted with OOM for the sigq allocation.  Modulo that nit,
this is fine by me.  (It is likely nobody will ever see this path anyway,
since we'll probably merge the clean-up that replaces it before any release
that uses this series at all.)

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/