linux-kernel - Re: [PATCH] IB/mthca: replace dma_sync_single with dma_sync_single_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090529082417G.fujita.tomonori@lab.ntt.co.jp>
Date:	Fri, 29 May 2009 08:23:51 +0900
From:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
To:	rdreier@...co.com
Cc:	fujita.tomonori@....ntt.co.jp, rolandd@...co.com,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] IB/mthca: replace dma_sync_single with
 dma_sync_single_for_cpu

On Thu, 28 May 2009 15:18:21 -0700
Roland Dreier <rdreier@...co.com> wrote:

>  > This replaces dma_sync_single() with dma_sync_single_for_cpu() because
>  > dma_sync_single() is an obsolete API; include/linux/dma-mapping.h says:
>  > 
>  > /* Backwards compat, remove in 2.7.x */
> 
> Thanks for pointing this out... however I think sync_single_for_cpu
> looks wrong in these cases -- I think there should be a pair of
> sync_single_for_cpu/sync_single_for_device around this stuff.

Yeah, possibly. I just convert it without looking at the code. As you
know, the patch will not change anything. If dma_sync_single_for_cpu
doesn't work here, the driver is already broken.


> I'll take a closer look in the next day or too.

Cool, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/