linux-kernel - Re: [PATCH] regulator/max1586: fix V3 gain calculation integer overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243587853.23130.2359.camel@vega.slimlogic.co.uk>
Date:	Fri, 29 May 2009 10:04:13 +0100
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Robert Jarzmik <robert.jarzmik@...e.fr>
Cc:	Philipp Zabel <philipp.zabel@...il.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator/max1586: fix V3 gain calculation integer
 overflow

On Thu, 2009-05-28 at 22:36 +0200, Robert Jarzmik wrote:
> Philipp Zabel <philipp.zabel@...il.com> writes:
> 
> > On Thu, May 28, 2009 at 10:59 AM, Mark Brown <broonie@...nsource.wolfsonmicro.com> wrote:
> >> On Thu, May 28, 2009 at 07:15:16AM +0200, Philipp Zabel wrote:
> >>> The V3 regulator can be configured with an external resistor
> >>> connected to the feedback pin (R24 in the data sheet) to
> >>> increase the voltage range.
> >>>
> >>> For example, hx4700 has R24 = 3.32 kOhm to achieve a maximum
> >>> V3 voltage of 1.55 V which is needed for 624 MHz CPU frequency.
> >>>
> >>> Signed-off-by: Philipp Zabel <philipp.zabel@...il.com>
> >>
> >> Looks good.
> >>
> >> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> >
> > Thanks, but it turns out I hit a 32 bit integer overflow in
> > the gain calculation. I'd like to mend that with the following
> > patch. Now max_uV could be increased up to 4.294 V, enough to
> > charge LiPo cells.
> >
> > Signed-off-by: Philipp Zabel <philipp.zabel@...il.com>
> OK.
> 
> With that one melt into the previous one, have my :
> Acked-by: Robert Jarzmik <robert.jarzmik@...e.fr>
> 
> Would you submit that to Liam or Mark for queuing into the regulator patch queue ?
> 

Both patches now applied.

Thanks

Liam


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/