linux-kernel - Re: [PATCH RFC] perf_counter: Don't swap contexts containing locked mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1243595850.23657.213.camel@twins>
Date:	Fri, 29 May 2009 13:17:30 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] perf_counter: Don't swap contexts containing
 locked mutex

On Fri, 2009-05-29 at 21:13 +1000, Paul Mackerras wrote:
> Ingo Molnar writes:
> 
> > looping in the remove-context retry loop.
> 
> Ah! We need to reload task inside the loop.  And possibly in other
> places.

Thing is, after your patch this is called after the unclone, so the
context should be stable, still we see this. But yeah that loop needs
some care.

I also noticed we have races on cpuctx->task_ctx, I was looking at
removing it alltogether in favour of current->perf_counter_ctxp.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/