linux-kernel - Re: [PATCH 3/4] [MTD] compat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905291602.37190.arnd@arndb.de>
Date:	Fri, 29 May 2009 16:02:36 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Kevin Cernekee <kpc.mtd@...il.com>,
	Adrian Hunter <adrian.hunter@...ia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux MTD <linux-mtd@...ts.infradead.org>
Subject: Re: [PATCH 3/4] [MTD] compat_ioctl cleanup

On Friday 29 May 2009, David Woodhouse wrote:
> On Wed, 2009-04-08 at 22:53 -0700, Kevin Cernekee wrote:
> > 
> > +static long mtd_compat_ioctl(struct file *file, unsigned int cmd,
> > +       unsigned long arg)
> > +{
> > +       struct mtd_file_info *mfi = file->private_data;
> > +       struct mtd_info *mtd = mfi->mtd;
> > +       void __user *argp = (void __user *)arg;
> 
> Shouldn't that be 'argp = compat_ptr(arg)' ?

Yes, that's right. I missed this when I looked at the patches.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/