linux-kernel - Re: [PATCH] 8250: Fix oops from setserial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090530114632.7f101b9a@lxorguk.ukuu.org.uk>
Date:	Sat, 30 May 2009 11:46:32 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org,
	vvscore@...il.com
Subject: Re: [PATCH] 8250: Fix oops from setserial

> Sure, huge numbers of drivers use the cast.
> 
> But I've never seen past sinnings as being a reason to continue sinning. 
> Doing new code the right way doesn't result in worse code, and reduces
> the chances of someone copying and pasting the wrong way.

As I said please read the rest of the driver. It would ridiculous to have
one dereference done differently to the rest in several thousand lines of
code.

It's not a new driver, it's simply pasting a line from one place to
another to update a field.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/