linux-kernel - Re: [PATCH] tracing/events: fix a typo in _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 31 May 2009 13:58:23 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tracing/events: fix a typo in __string() format output

ping..

Could someone apply this patch? I have a patchset, that
introduces __dynamic_array(), based on this fix.

Or I will include this fix in the patchset.

Li Zefan wrote:
> It should be '\t'. Also remove the space before "__str_loc".
> 
> Before:
>  # cat tracing/events/irq/irq_handler_entry/format
>         ...
>         field:int irq;  offset:12;      size:4;
>         field: __str_loc name;  offset:16;tsize:2;
>         ...
> 
> After:
>  # cat tracing/events/irq/irq_handler_entry/format
> 	...
>         field:int irq;  offset:12;      size:4;
>         field:__str_loc name;   offset:16;      size:2;
> 	...
> 
> [ Impact: fix the output of __string field in format file ]
> 
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>
> ---
>  include/trace/ftrace.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> index edb02bc..006af4c 100644
> --- a/include/trace/ftrace.h
> +++ b/include/trace/ftrace.h
> @@ -187,8 +187,8 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags)	\
>  
>  #undef __string
>  #define __string(item, src)						       \
> -	ret = trace_seq_printf(s, "\tfield: __str_loc " #item ";\t"	       \
> -			       "offset:%u;tsize:%u;\n",			       \
> +	ret = trace_seq_printf(s, "\tfield:__str_loc " #item ";\t"	       \
> +			       "offset:%u;\tsize:%u;\n",		       \
>  			       (unsigned int)offsetof(typeof(field),	       \
>  					__str_loc_##item),		       \
>  			       (unsigned int)sizeof(field.__str_loc_##item));  \

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/