linux-kernel - [PATCH 0/4] partitions/ide: improve Host Protected Area handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090531143911.7164.26834.sendpatchset@localhost.localdomain>
Date:	Sun, 31 May 2009 16:39:11 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	linux-ide@...r.kernel.org
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	"Andries E. Brouwer" <Andries.Brouwer@....nl>,
	linux-kernel@...r.kernel.org,
	Robert Hancock <hancockrwd@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Frans Pop <elendil@...net.nl>
Subject: [PATCH 0/4] partitions/ide: improve Host Protected Area handling

Hi,

Since from the perspective of most users of recent systems, disabling
Host Protected Area (HPA) can break vendor RAID formats, GPT partitions
and risks corrupting firmware or overwriting vendor system recovery tools
this patchset makes the IDE subsystem preserve HPA by default.

Unfortunately the original (kernels < 2.6.30) behavior (unconditionally
disabling HPA and using full disk capacity) was introduced at the time
when the main use of HPA was to make the drive look small enough for the
BIOS to allow the system to boot with large capacity drives.

Thus to allow the maximum compatibility with the existing setups (using
HPA and partitioned with HPA disabled) we automatically disable HPA if
any partitions overlapping HPA are detected.  Additionally HPA can also
be disabled using the "nohpa" module parameter (i.e. "ide_core.nohpa=0.0"
to disable HPA on /dev/hda).

I tested it with artificially created HPA (using 'hdparm -N p', kudos to
Mark Lord for that) and it worked as expected:

	hda: Host Protected Area detected.
		current capacity is 117210000 sectors (60011 MB)
		native  capacity is 117210240 sectors (60011 MB)
	hda: 117210000 sectors (60011 MB) w/7884KiB Cache, CHS=16383/255/63
	hda: cache flushes supported
	 hda: hda1 hda2 hda3 hda4 < hda5 hda6 >
	hda: p6 size 44869482 exceeds device capacity, enabling native capacity
	hda: detected capacity change from 60011520000 to 60011642880

Thanks to Robert Hancock, Frans Pop and Andries E. Brouwer for input/ideas on
previous (now obsoleted) HPA patches.

[ Robert, it seems possible to use ->set_capacity block device method also in
  libata to improving HPA handling and fix previously discussed compatibility
  issue. ]

patches:
 #01: warn about the partition exceeding device capacity in rescan_partions()

 #02: add ->set_capacity method to struct block_device_operations and use it
      in rescan_partitions() to enable native device capacity if any partition
      exceeding device capacity is detected

 #03: implement ->set_capacity method in ide-gd device driver to handle HPA

 #04: change the original kernel behavior and preserve HPA by default

 For easier testing the combined patch against 2.6.30-rc7 is available here:

	http://www.kernel.org/pub/linux/kernel/people/bart/hpa-2.6.30-rc7.patch

diffstat:
 Documentation/ide/ide.txt           |    2 +
 Documentation/kernel-parameters.txt |    7 +-----
 drivers/ide/ide-disk.c              |   22 ++++++++++++++++++
 drivers/ide/ide-gd.c                |   14 ++++++++++++
 drivers/ide/ide.c                   |   10 ++++++++
 fs/partitions/check.c               |   42 +++++++++++++++++++++++++++---------
 include/linux/blkdev.h              |    2 +
 include/linux/genhd.h               |    1 
 include/linux/ide.h                 |    6 +++--
 9 files changed, 88 insertions(+), 18 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/