linux-kernel - Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure of dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A23A72E.3020506@gmail.com>
Date:	Mon, 01 Jun 2009 12:02:22 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	vibi_sreenivasan@....com
CC:	Mimi Zohar <zohar@...ibm.com>, Kylene Hall <kylene@...ibm.com>,
	Serge Hallyn <serue@...ibm.com>,
	Reiner Sailer <sailer@...son.ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Eric Paris <eparis@...hat.com>
Subject: Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure
 of dentry_open]

On 06/01/2009 11:59 AM, Jiri Slaby wrote:
> On 06/01/2009 11:46 AM, vibi sreenivasan wrote:
>>>>>  	mutex_unlock(&iint->mutex);
>>>>> -	if (file)
>>>>> +	if (!IS_ERR(file))
>>>>>  		fput(file);
>>>>
>>>> No, IS_ERR won't catch NULL and there is 'file = NULL' on the
>>>> dentry_open fail path.
>> Can you please point out that line number in fs/open.c
> 
> Aha, you use linus's git. This has been fixed by
> f06dd16a03f6f7f72fab4db03be36e28c28c6fd6
> (IMA: Handle dentry_open failures)
> in -next.

[But the fix in -next still misses 'return 0' -> 'return rc' which I
though you had tried to change.]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/