linux-kernel - Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure of dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF4496A6A3.97A7AC73-ON852575C8.004E887B-852575C8.0051176D@us.ibm.com>
Date:	Mon, 1 Jun 2009 10:45:43 -0400
From:	Mimi Zohar <zohar@...ibm.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Eric Paris <eparis@...hat.com>, Kylene J Hall <kylene@...ibm.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Reiner Sailer <sailer@...son.ibm.com>,
	serue@...ux.vnet.ibm.com, vibi_sreenivasan@....com,
	safford@...son.ibm.com
Subject: Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure of
 dentry_open]

Jiri Slaby <jirislaby@...il.com> wrote on 06/01/2009 06:02:22 AM:

> Re: [Fwd: Re: [PATCH]:RESEND : Return proper error value on failure of 
dentry_open]
> 
> On 06/01/2009 11:59 AM, Jiri Slaby wrote:
> > On 06/01/2009 11:46 AM, vibi sreenivasan wrote:
> >>>>>     mutex_unlock(&iint->mutex);
> >>>>> -   if (file)
> >>>>> +   if (!IS_ERR(file))
> >>>>>        fput(file);
> >>>>
> >>>> No, IS_ERR won't catch NULL and there is 'file = NULL' on the
> >>>> dentry_open fail path.
> >> Can you please point out that line number in fs/open.c
> > 
> > Aha, you use linus's git. This has been fixed by
> > f06dd16a03f6f7f72fab4db03be36e28c28c6fd6
> > (IMA: Handle dentry_open failures)
> > in -next.
> 
> [But the fix in -next still misses 'return 0' -> 'return rc' which I
> though you had tried to change.]

At this point, we're just collecting measurements, not appraising 
them. The return code will be the result of appraise_measurement(). 
For now, the dentry_open shouldn't fail, but if it does, we probably
should audit it.

Mimi Zohar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/