linux-kernel - Re:[RFC/PATCH PATCH 6/6] lockdep: Consider the rw_state of lock while validating the chain.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2674af740905312205v645b5ba1n76ea4f34cb4f8051@mail.gmail.com>
Date:	Mon, 1 Jun 2009 13:05:47 +0800
From:	Yong Zhang <yong.zhang0@...il.com>
To:	ego@...ibm.com
Cc:	linux-kernel@...r.kernel.org
Subject: Re:[RFC/PATCH PATCH 6/6] lockdep: Consider the rw_state of lock while 
	validating the chain.

<...>
>@@ -1767,9 +1773,15 @@ static int validate_chain(struct task_struct *curr, struct lockdep_map *lock,
>
> 		if (!ret)
> 			return 0;
>+
>+		if (ret != 2 && is_rec_read(hlock->rw_state))
>+			hlock->rw_state |= STATE_FIRST_RECURSIVE_READ;
>+
>+
> 		/*
> 		 * Add dependency only if this lock is not the head
>-		 * of the chain, and if it's not a secondary read-lock:
>+		 * of the chain, and if it's not the first instance of
>+		 * the recursive read-lock:

This change maybe don't show what you want to say.
Maybe it should be "or if it's the first instance of the recursive read-lock."

> 		 */
> 		if (!chain_head && ret != 2)
> 			if (!check_prevs_add(curr, hlock))
<...>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/