lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <200906020110.06135.elendil@planet.nl>
Date:	Tue, 2 Jun 2009 01:10:05 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Luming Yu <luming.yu@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC patch] reset TSC at the begining of check_tsc_warp

Luming Yu wrote:
> Without this patch, we always get kernel warning that TSC warp between
> CPUs, and TSC is marked unstable due to check_tsc_sync_source failed if
> the CPUs have the problem of not-synced initial TSC.
> 
> It hurts CPUs with constant-tsc feature, but with unsynced initial TSC
> value...
> 
> The downside is we could break perfect synced TSC with this patch.
> Please review, test and apply.

I've tested this on my desktop (working TSC) and my laptop (non-working TSC).
On both machines the patch didn't make any difference.

Desktop: Intel mainboard, ICH7 chipset, dual core Pentium D 3.20GHz
$ dmesg | grep -i tsc
Fast TSC calibration using PIT
checking TSC synchronization [CPU#0 -> CPU#1]: passed.

Laptop: HP 2510p notebook, ICH8 chipset, Core2 Duo 1.33GHz
$ dmesg | grep -i tsc
Fast TSC calibration using PIT
checking TSC synchronization [CPU#0 -> CPU#1]: passed.
Marking TSC unstable due to TSC halts in idle
Clocksource tsc unstable (delta = -98164364 ns)

Tested on top of today's mainline git.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ