linux-kernel - Re: [PATCH v2 001/001] gpio: AMD CS5535/CS5536 GPIO driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17be05570906020114k7f2a3096h48335d509951cf90@mail.gmail.com>
Date:	Tue, 2 Jun 2009 10:14:45 +0200
From:	Tobias Müller <Tobias_Mueller@...m.info>
To:	jordan@...micpenguin.net
Cc:	Andres Salomon <dilinger@...labora.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>, david-b@...bell.net,
	gardner.ben@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 001/001] gpio: AMD CS5535/CS5536 GPIO driver

2009/6/2 Jordan Crouse <jordan@...micpenguin.net>:
> Andres Salomon wrote:
>> As far as Tobias's driver, one major difference between our drivers is
>> that mine doesn't grab the entire PCI device.  This is because other
>> drivers (ie, the MFGPT driver) will want to share the PCI device.
>
> Also SMBUS. In fact, they *must* share the PCI device if they all want to
> play well together, so that alone would probably push us toward Andre's
> patch, once it gets clean.

I had SMBUS and my driver tested in parallel and there I didn't found any
problems. But I would be fine if we would use Andre's patch. I haven't know
about, so that's why I tried my own. :)

I see some other problem's on Andre's patch:
- He allows the use of PIN 23 which is reserved
- No special handling is done for 28, which is a GPIO, but
  serves as Power Button as well
- OUT_AUX1/OUT_AUX2 should be disabled by default
  if pin is configured as in output
- IN_AUX should be disabled by default is pin is
  configured as in input

And, if I request a GPIO by userspace via sysfs, on my system it's an
input pin by default. So my driver initializes a GPIO as an input by default.
But I don't know if this is default or system specific. I didn't found anything
about this in the gpio docs.

So maybe we should decide whether we take Andre's or my approach
and then adjust it.

Tobias
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/