linux-kernel - Re: [PATCH 04/11] Blackfin SPORT UART: fix overrun errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090602100018.415b1dfc@lxorguk.ukuu.org.uk>
Date:	Tue, 2 Jun 2009 10:00:18 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Cliff Cai <cliff.cai@...log.com>,
	Bryan Wu <cooloney@...nel.org>
Subject: Re: [PATCH 04/11] Blackfin SPORT UART: fix overrun errors

On Tue,  2 Jun 2009 03:11:33 -0400
Mike Frysinger <vapier@...too.org> wrote:

> From: Cliff Cai <cliff.cai@...log.com>
> 
> Push the ty_flip_buffer_push() call from the IRQ handler to a timer so as
> to improve performance and decrease likelihood of overruns.

This should have no effect on a modern kernel. There is 64K of queueing
between you and the ldisc nowdays. Furthermore unless you set
tty->low_latency the kernel already basically does this aggregation for
you as the buffer push queues stuff for the ldisc to wake up and process.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/