linux-kernel - Re: [PATCH] mISDN GIT: hfcpci cleanup failure on IRQ weirdness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906021653.36152.isdn@linux-pingi.de>
Date:	Tue, 2 Jun 2009 16:53:35 +0200
From:	Karsten Keil <isdn@...ux-pingi.de>
To:	Andreas Mohr <andi@...as.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mISDN GIT: hfcpci cleanup failure on IRQ weirdness

On Dienstag, 2. Juni 2009 16:02:50 you wrote:
> Hi,
>
> > I have the suspicion that maybe I shouldn't be loading hisax upon boot
> > (and then immediately removing it before launching mISDN stuff),
> > since hfcpci acts very weird - perhaps it cannot recover card state fully
> > after hisax fumbling.
>
> Indeed, manually killed all hisax modules on the system, rebooted, and -
> it worked, immediately!
> (test call SIP -> Asterisk -> LCR -> ISDN -> out -> ISDN)
>
> IOW, we've got an unfortunate driver init state handling issue which one
> should perhaps investigate to make the driver more robust against
> varying hardware state.
> (my IRQ patch was a first step I guess ;)
>

Yes from mISDN side, but I do not see what inside hisax prevent mISDN from
getting IRQs after hisax was unloaded. And it works here on my test setup, I 
can load mISDN without an error, after unloading hisax.
One other issue with the HiSax  HFC PCI code is the FIFO DMA memory
allocation, this code is wrong  and broken (patch is under test).

> misdn_log still acts weird, though...
>
What does be weird here ?

> Thanks for all your important ISDN work! (given the sizeable number of
> commits mISDN will rather soon get there I think)
>
> BTW, could isdnlog be adapted to support mISDN relatively easily?
> (since adding CAPI support would take longer I guess)

isdnlog (beside that the isdnlog code is ugly enough) should be not a big 
issue, mISDN supports logging in parallel to the normal work, look at the
tools/loghex.c  code how to create a logging socket.
It should make things easier as with HiSax, since it will get the data as 
binary and not as hexdump.

> My guys are going semi-ballistic with their isdnlog taken out and shot ;)
>
> Andreas Mohr
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/