linux-kernel - Re: [PATCH 2/5] TOMOYO: Clarify lock protected section.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906020230.n522UjfJ013581@www262.sakura.ne.jp>
Date:	Tue, 02 Jun 2009 11:30:45 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:	lizf@...fujitsu.com
Cc:	linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] TOMOYO: Clarify lock protected section.

Li Zefan wrote:
> Tetsuo Handa wrote:
> > Enclose reader section in
> > 	/***** READER SECTION START *****/
> > and
> > 	/***** READER SECTION END *****/
> > and writer section in
> > 	/***** WRITER SECTION START *****/
> > and
> > 	/***** WRITER SECTION END *****/
> > in order to avoid oversighting lock protected section.
> > 
> 
> This makes me a bit uncomfortable..
> 
> IMHO this seems ugly, useless, and even harmful. If it's helpful,
> we'd be doing this for the whole kernel tree, which is crazy..
> 
> Or does tomoyo do this for it's special reason?

I intended to help reviewers to visualize the range of protected section
at a glance. But if reviewers feel noisy, I can remove these markers.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/