linux-kernel - [PATCH] tracing/mm: val should be signed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 03 Jun 2009 00:57:20 +0200
From:	Roel Kluin <roel.kluin@...il.com>
To:	rostedt@...dmis.org
CC:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] tracing/mm: val should be signed

If not signed the `val < 0' test below doesn't make sense.
Also strict_strtol requires a long pointer.

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
---
I think this is what was intended? please review.

diff --git a/kernel/trace/trace_mm.c b/kernel/trace/trace_mm.c
index 4bc7fc0..9af2351 100644
--- a/kernel/trace/trace_mm.c
+++ b/kernel/trace/trace_mm.c
@@ -54,7 +54,8 @@ static ssize_t
 trace_mm_dump_range_write(struct file *filp, const char __user *ubuf, size_t cnt,
 		       loff_t *ppos)
 {
-	unsigned long val, start, end;
+	unsigned long start, end;
+	long val;
 	char buf[64];
 	int ret;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/