[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090602040538.GA21698@hallyn.com>
Date: Mon, 1 Jun 2009 23:05:38 -0500
From: "Serge E. Hallyn" <serge@...lyn.com>
To: Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc: linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] Move sleeping operations to outside the semaphore.
Quoting Tetsuo Handa (penguin-kernel@...ove.sakura.ne.jp):
> TOMOYO is using rw_semaphore for protecting list elements.
> But TOMOYO is doing operations which might sleep inside down_write().
> This patch makes TOMOYO's sleeping operations go outside down_write().
Hi Tetsuo,
another thing making these patches hard for me to review is the lack of
documentation to start with. There are lists of policy managers, domain
initializers, etc, and I don't know what they are.
Could you flesh out Documentation/tomoyo.txt and/or the variable, struct,
and function definitions under security/tomoyo/ with some explanations?
(A fn comment like
* tomoyo_update_manager_entry - Add a manager entry.
is not helpful)
That should help me sound less ignorant in the future...
thanks,
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists