linux-kernel - Re: [PATCH 2/3] tracing/events: fix output format of kernel stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0906031022540.14994@gandalf.stny.rr.com>
Date:	Wed, 3 Jun 2009 10:23:08 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	walimis <walimisdev@...il.com>
cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] tracing/events: fix output format of kernel stack



On Wed, 3 Jun 2009, walimis wrote:

> According to "events/ftrace/kernel_stack/format", output format of
> kernel stack should use "=>" instead of "<=".
> 
> The second problem is that we shouldn't skip the first entry in the stack,
> although it seems to be duplicated when used in the "function" tracer,
> but events also use it. If we skip the first one, we will drop the topmost
> entry of the stack.
> 
> The last problem is that if the last entry is ULONG_MAX(0xffffffff), we should
> drop it, otherwise it will print a NULL name line.
> 
> before fix:
> 
>       sh-1072  [000]   26.957239: sched_process_fork: parent sh:1072 child sh:1073
>       sh-1072  [000]   26.957262:
>  <= syscall_call
>  <=
>       sh-1072  [000]   26.957744: sched_switch: task sh:1072 [120] (R) ==> sh:1073 [120]
>       sh-1072  [000]   26.957752:
>  <= preempt_schedule
>  <= wake_up_new_task
>  <= do_fork
>  <= sys_clone
>  <= syscall_call
>  <=
> 
> After fix:
> 
>       sh-1075  [000]    39.791848: sched_process_fork: parent sh:1075  child sh:1076
>       sh-1075  [000]    39.791871:
>  => sys_clone
>  => syscall_call
>       sh-1075  [000]    39.792713: sched_switch: task sh:1075 [120] (R) ==> sh:1076 [120]
>       sh-1075  [000]    39.792722:
>  => schedule
>  => preempt_schedule
>  => wake_up_new_task
>  => do_fork
>  => sys_clone
>  => syscall_call
> 
> Signed-off-by: walimis <walimisdev@...il.com>

I'll queue this up. Thanks!

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/