linux-kernel - Re: [PATCH v3] MFD: PCAP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <10f740e80906030738x3b42de18n189367b28a730c56@mail.gmail.com>
Date:	Wed, 3 Jun 2009 16:38:19 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Daniel Ribeiro <drwyrm@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Harald Welte <laforge@...monks.org>,
	Philipp Zabel <philipp.zabel@...il.com>,
	openezx-devel <openezx-devel@...ts.openezx.org>,
	linux-next@...r.kernel.org
Subject: Re: [PATCH v3] MFD: PCAP driver

On Wed, May 27, 2009 at 06:42, Daniel Ribeiro <drwyrm@...il.com> wrote:
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -241,6 +241,13 @@ config PCF50633_GPIO
>         Say yes here if you want to include support GPIO for pins on
>         the PCF50633 chip.
>
> +config EZX_PCAP
> +       bool "PCAP Support"
> +       depends on SPI_MASTER

It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type():

> +       set_irq_type(spi->irq, IRQ_TYPE_EDGE_RISING);

Cfr. the m68k allmodconfig build failure on linux-next
http://kisskb.ellerman.id.au/kisskb/buildresult/595604/:

drivers/mfd/ezx-pcap.c:123: error: implicit declaration of function
'get_irq_chip_data'
drivers/mfd/ezx-pcap.c:179: error: implicit declaration of function
'note_interrupt'
drivers/mfd/ezx-pcap.c:189: error: implicit declaration of function
'get_irq_data'
drivers/mfd/ezx-pcap.c:370: error: implicit declaration of function
'set_irq_chip_and_handler'
drivers/mfd/ezx-pcap.c:426: error: 'handle_simple_irq' undeclared
(first use in this function)
drivers/mfd/ezx-pcap.c:426: error: (Each undeclared identifier is
reported only once
drivers/mfd/ezx-pcap.c:426: error: for each function it appears in.)
drivers/mfd/ezx-pcap.c:427: error: implicit declaration of function
'set_irq_chip_data'
drivers/mfd/ezx-pcap.c:431: error: implicit declaration of function
'set_irq_noprobe'
drivers/mfd/ezx-pcap.c:440: error: implicit declaration of function
'set_irq_type'
drivers/mfd/ezx-pcap.c:441: error: implicit declaration of function
'set_irq_data'
drivers/mfd/ezx-pcap.c:442: error: implicit declaration of function
'set_irq_chained_handler'
drivers/mfd/ezx-pcap.c:443: error: implicit declaration of function
'set_irq_wake'

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/