linux-kernel - Re: [patch] epoll - send POLLHUP on ->release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A26CCFA.7050105@novell.com>
Date:	Wed, 03 Jun 2009 15:20:26 -0400
From:	Gregory Haskins <ghaskins@...ell.com>
To:	Davide Libenzi <davidel@...ilserver.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch] epoll - send POLLHUP on ->release

Davide Libenzi wrote:
> The following patch allows waiters to be notified about the eventfd file* 
> going away, and give them a change to unregister from the wait queue.
> This is turn allows eventfd users to use the eventfd file* w/out 
> holding a live reference to it.
> After the eventfd user callbacks returns, any usage of the eventfd file* 
> should be dropped. The eventfd user callback can acquire sleepy locks 
> since it is invoked lockless.
>
>
>
> Signed-off-by: Davide Libenzi <davidel@...ilserver.org>
>   

Tested-by: Gregory Haskins <ghaskins@...ell.com>
>
> - Davide
>
>
> ---
>  fs/eventfd.c |   10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
>
> Index: linux-2.6.mod/fs/eventfd.c
> ===================================================================
> --- linux-2.6.mod.orig/fs/eventfd.c	2009-05-27 12:10:03.000000000 -0700
> +++ linux-2.6.mod/fs/eventfd.c	2009-05-27 12:16:57.000000000 -0700
> @@ -59,7 +59,15 @@ int eventfd_signal(struct file *file, in
>  
>  static int eventfd_release(struct inode *inode, struct file *file)
>  {
> -	kfree(file->private_data);
> +	struct eventfd_ctx *ctx = file->private_data;
> +
> +	/*
> +	 * No need to hold the lock here, since we are on the file cleanup
> +	 * path and the ones still attached to the wait queue will be
> +	 * serialized by wake_up_locked_poll().
> +	 */
> +	wake_up_locked_poll(&ctx->wqh, POLLHUP);
> +	kfree(ctx);
>  	return 0;
>  }
>  
>   



Download attachment "signature.asc" of type "application/pgp-signature" (267 bytes)