linux-kernel - Re: + cgroups-forbid-noprefix-if-mounting-more-than-just-cpuset-subsystem. patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090603052053.GA3910@linux.vnet.ibm.com>
Date:	Wed, 3 Jun 2009 10:50:53 +0530
From:	Dhaval Giani <dhaval@...ux.vnet.ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	menage@...gle.com, lizf@...fujitsu.com, balbir@...ux.vnet.ibm.com,
	kamezawa.hiroyu@...fujitsu.com, linux-kernel@...r.kernel.org,
	bharata@...ux.vnet.ibm.com, libcg-devel@...ts.sourceforge.net
Subject: Re: +
	cgroups-forbid-noprefix-if-mounting-more-than-just-cpuset-subsystem.
	patch added to -mm tree

On Tue, Jun 02, 2009 at 01:35:34PM -0700, Andrew Morton wrote:
> On Tue, 2 Jun 2009 23:10:42 +0530
> Dhaval Giani <dhaval@...ux.vnet.ibm.com> wrote:
> 
> > On Tue, Jun 02, 2009 at 09:08:04AM -0700, Paul Menage wrote:
> > > On Tue, Jun 2, 2009 at 2:09 AM, Dhaval Giani <dhaval@...ux.vnet.ibm.com> wrote:
> > > >
> > > > I am not sure if this is a good idea. For libcgroup, we would then be
> > > > adding a special case for just cpuset. I would rather that we allow it
> > > > either for all the subsystems or none of them.
> > > >
> > > 
> > > libcgroup shouldn't be using the noprefix option. Its only intentded
> > > use is to allow the legacy "cpuset" filesystem type to be mounted and
> > > to see the same fileset as it had before the cgroups transition.
> > > 
> > 
> > It does not. But if some user is using that option, we need to be in a
> > position to handle it.
> > 
> > I am quite happy not supporting the noprefix option in the library if it
> > is fine.
> > 
> 
> fyi, the above discussion transitions akpm into the "confused" state. 
> I'll keep the patch on hold until akpm transitions back out of that
> state.

I can help with that :).

We will not support noprefix in libcgroup and this patch should go in
because it fixes an obvious bug.

Thanks,
-- 
regards,
Dhaval
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/