linux-kernel - Re: [PATCH v2] usb: avoid PM error messages during resume if a device was disconnected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.0906022056070.8257-100000@netrider.rowland.org>
Date:	Tue, 2 Jun 2009 20:57:46 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	Frans Pop <elendil@...net.nl>, <linux-usb@...r.kernel.org>,
	<linux-pm@...ts.linux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] usb: avoid PM error messages during resume if a device
 was disconnected

On Wed, 3 Jun 2009, Rafael J. Wysocki wrote:

> > +	/* Avoid PM error messages for devices disconnected while suspended
> > +	 * as we'll display regular disconnect messages just a bit later.
> > +	 */
> > +	if (status == -ENODEV)
> > +		return 0;
> > +	return status;
> 
> + return status == -ENODEV ? 0 : status;
> 
> maybe?
> 
> >  }
> >  
> >  #endif /* CONFIG_PM */

Personally, I would do:

	if (status == -ENODEV)
		status = 0;
	return status;

It doesn't make any difference; they are all equally good.

Acked-by: Alan Stern <stern@...land.harvard.edu>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/