linux-kernel - Re: [PATCH] gpio sysfs: add a "toggle" value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0906040116v659d0cdetaff267f4241be175@mail.gmail.com>
Date:	Thu, 4 Jun 2009 04:16:14 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Brownell <david-b@...bell.net>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio sysfs: add a "toggle" value

On Thu, Jun 4, 2009 at 03:54, Andrew Morton wrote:
> On Wed,  3 Jun 2009 04:16:59 -0400 Mike Frysinger wrote:
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>
> -ENOCHANGELOGAGAIN

it's pretty damned self explanatory

>> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
>> index 51a8d41..7f79732 100644
>> --- a/drivers/gpio/gpiolib.c
>> +++ b/drivers/gpio/gpiolib.c
>> @@ -274,7 +274,12 @@ static ssize_t gpio_value_store(struct device *dev,
>>       else {
>>               long            value;
>>
>> -             status = strict_strtol(buf, 0, &value);
>> +             if (sysfs_streq(buf, "toggle")) {
>> +                     value = !gpio_get_value_cansleep(gpio);
>> +                     status = 0;
>> +             } else
>> +                     status = strict_strtol(buf, 0, &value);
>> +
>>               if (status == 0) {
>>                       gpio_set_value_cansleep(gpio, value != 0);
>>                       status = size;
>
> A suitable place to document this is Documentation/gpio.txt.

yes, but i wanted to make sure David didnt reject the idea before i
spend time writing documentation.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/