[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4A27927E.9090800@redhat.com>
Date: Thu, 04 Jun 2009 17:23:10 +0800
From: Amerigo Wang <amwang@...hat.com>
To: Sam Ravnborg <sam@...nborg.org>
CC: linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
linux-kbuild@...r.kernel.org
Subject: Re: [Patch 1/2] kbuild: two trivial fixes for check headers
Sam Ravnborg wrote:
> On Thu, Jun 04, 2009 at 04:01:52AM -0400, Amerigo Wang wrote:
>
>> Remove a useless 'extern' in an exported header.
>> Fix a comment headers_check.pl.
>>
>
> These two patches has nothing in commom.
>
They are both about kernel headers stuff.
>
>> Signed-off-by: WANG Cong <amwang@...hat.com>
>> Cc: Sam Ravnborg <sam@...nborg.org>
>>
>> ------
>> diff --git a/include/mtd/jffs2-user.h b/include/mtd/jffs2-user.h
>> index fa94b0e..10dc7ef 100644
>> --- a/include/mtd/jffs2-user.h
>> +++ b/include/mtd/jffs2-user.h
>> @@ -18,7 +18,7 @@
>> #undef je32_to_cpu
>> #undef jemode_to_cpu
>>
>> -extern int target_endian;
>> +int target_endian;
>>
>
> You now declare a global variable named target_endian each time you include this file - which is wrong.
>
Why? 'make headers_check' complains about it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists