linux-kernel - Re: [PATCH v2] add MAX17040 Fuel Gauge driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f3430fb0906040347m1079def5j7d820e18a9375eaa@mail.gmail.com>
Date:	Thu, 4 Jun 2009 19:47:43 +0900
From:	Minkyu Kang <promsoft@...il.com>
To:	Trilok Soni <soni.trilok@...il.com>
Cc:	Minkyu Kang <mk7.kang@...sung.com>, linux-kernel@...r.kernel.org,
	linux-pm@...ts.linux-foundation.org, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2] add MAX17040 Fuel Gauge driver

Hi, Trilok

> Adding linux-i2c mailing list, so not deleting any code.

Ok, I will.

>> +static struct max17040_chip *max17040;
>> +static struct max17040_platform_data *pdata;
>
> May be you want to move this pdata under chip structure.
>
>> +       i2c_set_clientdata(client, chip);
>
> Please add i2c_check_functionality check before doing any smbus
> read/write operations.
>

Ok, that's better.

>> +       max17040 = chip;
>
> This means that we support only one instance of this chip, right?
>

Yes right.. but, I think that is not a good way.
I'll modify it, too. thanks :)


-- 
from. prom.
promsoft.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/