linux-kernel - Re: [PATCH] gpio: Added timbgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A27C3B0.5000605@mocean-labs.com>
Date:	Thu, 04 Jun 2009 14:53:04 +0200
From:	Richard Röjfors 
	<richard.rojfors.ext@...ean-labs.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: Added timbgpio

Andrew Morton wrote:
> On Wed, 03 Jun 2009 10:07:48 +0200 Richard R____jfors  <richard.rojfors.ext@...ean-labs.com> wrote:
> 
>> Supplied is a GPIO driver for the Timberdale FPGA found on the
>> Intel Atom board Russellville.
>>
>> ...
>>
>> +EXPORT_SYMBOL(timbgpio_gpio_flnk_lvl_ctrl);
>> +EXPORT_SYMBOL(timbgpio_gpio_int_ctrl);
>> +EXPORT_SYMBOL(timbgpio_gpio_lvl_ctrl);
>> +EXPORT_SYMBOL(timbgpio_gpio_int_clr);
> 
> Why all these module exports?

Internal stuff, I will remove it.

>> ...
>>
>> +config GPIO_TIMBERDALE
>> +	tristate "Support for timberdale GPIO"
>> +	depends on MFD_TIMBERDALE && GPIOLIB
>> +	---help---
>> +	Add support for GPIO usage of some pins of the timberdale FPGA.
>> +
> 
> I cannot find anything which sets MFD_TIMBERDALE anywhere?

Sorry, I realize I have to come back with a bigger patch set.

Timberdale is the MFD driver for the FPGA which among other expose this GPIO device.
This patch set will depend on patches in i2c-ocores and xilinx_spi which I have posted
earlier on the corresponding mailinglists.
Shall I repost those driver changes within this patch set, or can I leave them out?

--Richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/