linux-kernel - sysfs_create_link_nowarn still remains (Was Re: mmotm 2009-06-03-16-33 uploaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090604123813.96c2c5a9.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Thu, 4 Jun 2009 12:38:13 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	linux-kernel@...r.kernel.org
Cc:	akpm@...ux-foundation.org, garyhade@...ibm.com, pbadari@...ibm.com,
	"y-goto@...fujitsu.com" <y-goto@...fujitsu.com>,
	ebiederm@...ssion.com, gregkh@...e.de
Subject: sysfs_create_link_nowarn still remains (Was Re: mmotm
 2009-06-03-16-33 uploaded

On Wed, 03 Jun 2009 16:33:52 -0700
akpm@...ux-foundation.org wrote:

> The mm-of-the-moment snapshot 2009-06-03-16-33 has been uploaded to
> 
>    http://userweb.kernel.org/~akpm/mmotm/
> 
> and will soon be available at
> 
>    git://git.zen-sources.org/zen/mmotm.git
> 
It seems sysfs_create_link_nowarn() is removed in linux-next.patch but
driver/base/node.c still includes it.

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=c04fc586c1a480ba198f03ae7b6cbd7b57380b91

How should we fix it ? Folllowing is a quick hack for compile but ...
should be clarified by memory hotplug guys.

==

sysfs_create_link_nowarn() is obsolete.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
---
Index: mmotm-2.6.30-Jun3/drivers/base/node.c
===================================================================
--- mmotm-2.6.30-Jun3.orig/drivers/base/node.c
+++ mmotm-2.6.30-Jun3/drivers/base/node.c
@@ -279,7 +279,7 @@ int register_mem_sect_under_node(struct 
 			continue;
 		if (page_nid != nid)
 			continue;
-		return sysfs_create_link_nowarn(&node_devices[nid].sysdev.kobj,
+		return sysfs_create_link(&node_devices[nid].sysdev.kobj,
 					&mem_blk->sysdev.kobj,
 					kobject_name(&mem_blk->sysdev.kobj));
 	}


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/