linux-kernel - Re: [PATCH v2 16/17] XFS: do not manipulate s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E951DADA-CAEF-4C4F-A644-23E14C2DF198@sgi.com>
Date:	Thu, 4 Jun 2009 14:00:12 -0500
From:	Felix Blyakher <felixb@....com>
To:	Artem Bityutskiy <dedekind@...radead.org>
Cc:	Al Viro <viro@...IV.linux.org.uk>, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Christoph Hellwig <hch@...radead.org>,
	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>,
	xfs-masters@....sgi.com
Subject: Re: [PATCH v2 16/17] XFS: do not manipulate s_dirt directly


On Jun 4, 2009, at 5:41 AM, Artem Bityutskiy wrote:

> From: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
>
> ... use new VFS helpers instead.
>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> Cc: Christoph Hellwig <hch@...radead.org>
> Cc: xfs-masters@....sgi.com
> Cc: Felix Blyakher <felixb@....com>

Acked-by: Felix Blyakher <felixb@....com>

>
> ---
> fs/xfs/linux-2.6/xfs_super.c |    6 +++---
> fs/xfs/xfs_trans.c           |    2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/ 
> xfs_super.c
> index d29218e..4c25456 100644
> --- a/fs/xfs/linux-2.6/xfs_super.c
> +++ b/fs/xfs/linux-2.6/xfs_super.c
> @@ -1114,7 +1114,7 @@ xfs_fs_write_super(
> {
> 	if (!(sb->s_flags & MS_RDONLY))
> 		xfs_sync_fsdata(XFS_M(sb), 0);
> -	sb->s_dirt = 0;
> +	mark_sb_clean(sb);
> }
>
> STATIC int
> @@ -1141,7 +1141,7 @@ xfs_fs_sync_super(
> 		error = xfs_quiesce_data(mp);
> 	else
> 		error = xfs_sync_fsdata(mp, 0);
> -	sb->s_dirt = 0;
> +	mark_sb_clean(sb);
>
> 	if (unlikely(laptop_mode)) {
> 		int	prev_sync_seq = mp->m_sync_seq;
> @@ -1447,7 +1447,7 @@ xfs_fs_fill_super(
>
> 	XFS_SEND_MOUNT(mp, DM_RIGHT_NULL, mtpt, mp->m_fsname);
>
> -	sb->s_dirt = 1;
> +	mark_sb_dirty(sb);
> 	sb->s_magic = XFS_SB_MAGIC;
> 	sb->s_blocksize = mp->m_sb.sb_blocksize;
> 	sb->s_blocksize_bits = ffs(sb->s_blocksize) - 1;
> diff --git a/fs/xfs/xfs_trans.c b/fs/xfs/xfs_trans.c
> index 8570b82..2552bae 100644
> --- a/fs/xfs/xfs_trans.c
> +++ b/fs/xfs/xfs_trans.c
> @@ -629,7 +629,7 @@ xfs_trans_apply_sb_deltas(
> 				  offsetof(xfs_dsb_t, sb_frextents) +
> 				  sizeof(sbp->sb_frextents) - 1);
>
> -	tp->t_mountp->m_super->s_dirt = 1;
> +	mark_sb_dirty(tp->t_mountp->m_super);
> }
>
> /*
> -- 
> 1.6.0.6
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/