linux-kernel - Re: [PATCH 0/6] headers_check fix patches 20090604

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090604201242.GB13892@uranus.ravnborg.org>
Date:	Thu, 4 Jun 2009 22:12:42 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Russell King <rmk+lkml@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Tony Luck <tony.luck@...el.com>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Greg Ungerer <gerg@...pgear.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Michael Abbott <michael@...neidae.co.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	David Howells <dhowells@...hat.com>
Subject: Re: [PATCH 0/6] headers_check fix patches 20090604

On Thu, Jun 04, 2009 at 05:53:52PM +0530, Jaswinder Singh Rajput wrote:
> Please Review :
> 
> Jaswinder Singh Rajput (6):
>       headers_check fix: arm, hwcap.h
>       headers_check fix: ia64, fpswa.h
>       headers_check fix: m68k, swab.h
>       headers_check fix: mips, ioctl.h
>       headers_check fix: mn10300, ptrace.h
>       headers_check fix: mn10300, setup.h

Please let the subject explain what was fixed.
The fact that you used headers_check to detect the
issue in the first place is less relevant.

For mips the subject could have been:

mips: use userspace compatible definition of _IOC_TYPECHECK

Did you concentrate solely on headers_check output
or did you carefully inspect the files you touched for userspace issues?
I stroingly recommend to fix all userspace issues in files touched
if this is possible.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/