| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LFD.2.01.0906041405030.4880@localhost.localdomain> Date: Thu, 4 Jun 2009 14:05:53 -0700 (PDT) From: Linus Torvalds <torvalds@...ux-foundation.org> To: Andrew Morton <akpm@...ux-foundation.org> cc: Salman Qazi <sqazi@...gle.com>, linux-kernel@...r.kernel.org, Nick Piggin <nickpiggin@...oo.com.au> Subject: Re: A bug in read operation for /dev/zero and a proposed fix. On Thu, 4 Jun 2009, Linus Torvalds wrote: > > If we want to do this for 2.6.30, though, I very much agree with the > notion of limiting it to just fatal signals, though. IOW, I really think the patch should look like the following, and that this has nothing to do with OOM-killing at all. Linus --- drivers/char/mem.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/char/mem.c b/drivers/char/mem.c index 8f05c38..65e12bc 100644 --- a/drivers/char/mem.c +++ b/drivers/char/mem.c @@ -694,6 +694,9 @@ static ssize_t read_zero(struct file * file, char __user * buf, written += chunk - unwritten; if (unwritten) break; + /* Consider changing this to just 'signal_pending()' with lots of testing */ + if (fatal_signal_pending(current)) + return written ? written : -EINTR; buf += chunk; count -= chunk; cond_resched(); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists