linux-kernel - Re: Linux 2.6.30-rc8 [also: VIA Support]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090604212454.GA20822@redhat.com>
Date:	Thu, 4 Jun 2009 17:24:54 -0400
From:	Dave Jones <davej@...hat.com>
To:	"Michael S. Zick" <lkml@...ethan.org>
Cc:	Harald Welte <HaraldWelte@...tech.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Duane Griffin <duaneg@...da.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.30-rc8 [also: VIA Support]

On Thu, Jun 04, 2009 at 04:01:30PM -0500, Michael S. Zick wrote:

 > But while your here, what is your opinion on this one,
 > in: int __init pcibios_init(void)
 > 
 > - - - - -
 >         pci_cache_line_size = 32 >> 2;
 >         if (c->x86 >= 6
 >         && (c->x86_vendor == X86_VENDOR_AMD) || (c->x86_vendor == X86_VENDOR_CENTAUR))
 >                 pci_cache_line_size = 64 >> 2;  /* K7 & K8 and VIA C7-M */
 >         else if (c->x86 > 6 && c->x86_vendor == X86_VENDOR_INTEL)
 >                 pci_cache_line_size = 128 >> 2; /* P4 */
 > 
 > Mike

C7's L1 cachelines are 64 bytes, so it's right in that case,
but the earlier Centaur CPUs are 32 bytes, so it should be checking steppings.

Or better yet, why not just set it to boot_cpu_data->x86_clflush_size ?

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/