linux-kernel - Re: [PATCH v3] MFD: PCAP driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090604225447.GA4806@sortiz.org>
Date:	Fri, 5 Jun 2009 00:54:49 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Daniel Ribeiro <drwyrm@...il.com>
Cc:	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Harald Welte <laforge@...monks.org>,
	Philipp Zabel <philipp.zabel@...il.com>,
	openezx-devel <openezx-devel@...ts.openezx.org>,
	linux-next <linux-next@...r.kernel.org>
Subject: Re: [PATCH v3] MFD: PCAP driver

Hi Daniel,

On Wed, Jun 03, 2009 at 09:20:56PM -0300, Daniel Ribeiro wrote:
> Em Qua, 2009-06-03 às 16:38 +0200, Geert Uytterhoeven escreveu: 
> > > +config EZX_PCAP
> > > +       bool "PCAP Support"
> > > +       depends on SPI_MASTER
> > 
> > It also has to depend on GENERIC_HARDIRQS, as it needs set_irq_type():
> 
> Hi Geert, sorry for this. :)
> 
> 
> 
> Fix EZX_PCAP dependency
> 
> Signed-off-by: Daniel Ribeiro <drwyrm@...il.com>
Thanks. Pushed to my for-next branch.
I fixed it on the original patch, to avoid having 2 commits.

Cheers,
Samuel.


> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 060ee14..6557d60 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -243,7 +243,7 @@ config PCF50633_GPIO
>  
>  config EZX_PCAP
>  	bool "PCAP Support"
> -	depends on SPI_MASTER
> +	depends on GENERIC_HARDIRQS && SPI_MASTER
>  	help
>  	  This enables the PCAP ASIC present on EZX Phones. This is
>  	  needed for MMC, TouchScreen, Sound, USB, etc..
> 
> -- 
> Daniel Ribeiro
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/