lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0906051157460.22218@melkki.cs.Helsinki.FI>
Date:	Fri, 5 Jun 2009 11:59:41 +0300 (EEST)
From:	Pekka J Enberg <penberg@...helsinki.fi>
To:	corentincj@...aif.net
cc:	acpi4asus-user@...ts.sourceforge.net, len.brown@...el.com,
	linux-kernel@...r.kernel.org
Subject: [PATCH] eeepc-laptop: enable camera by default

From: Pekka Enberg <penberg@...helsinki.fi>

If we leave the camera disabled by default, userspace programs (e.g. 
Skype, Cheese) leave the user out in the cold saying that the machine "has 
no camera." Therefore, it's better to enable camera by default and let 
people who really don't want it just disable the thing.

Cc: <acpi4asus-user@...ts.sourceforge.net>
Cc: Len Brown <len.brown@...el.com>
Signed-off-by: Pekka Enberg <penberg@...helsinki.fi>
---
 drivers/platform/x86/eeepc-laptop.c |   16 ++++++++++++++++
 1 files changed, 16 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
index 353a898..c0f8eb1 100644
--- a/drivers/platform/x86/eeepc-laptop.c
+++ b/drivers/platform/x86/eeepc-laptop.c
@@ -334,6 +334,19 @@ static int eeepc_bluetooth_rfkill_state(void *data, enum rfkill_state *state)
 }
 
 /*
+ * Camera helpers
+ */
+
+static void eeepc_enable_camera(void)
+{
+	int err;
+
+	err = set_acpi(CM_ASL_CAMERA, 1);
+	if (err)
+		printk(EEEPC_WARNING "Unable to enable camera %d\n", err);
+}
+
+/*
  * Sys helpers
  */
 static int parse_arg(const char *buf, unsigned long count, int *val)
@@ -996,6 +1009,9 @@ static int __init eeepc_laptop_init(void)
 	result = eeepc_hwmon_init(dev);
 	if (result)
 		goto fail_hwmon;
+
+	eeepc_enable_camera();
+
 	/* Register platform stuff */
 	result = platform_driver_register(&platform_driver);
 	if (result)
-- 
1.5.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ