linux-kernel - Re: [PATCH] shm: fix unused warnings on nommu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090605092332.GB8354@cr0.nay.redhat.com>
Date:	Fri, 5 Jun 2009 17:23:32 +0800
From:	Amerigo Wang <xiyou.wangcong@...il.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org, David Howells <dhowells@...hat.com>
Subject: Re: [PATCH] shm: fix unused warnings on nommu

On Fri, Jun 05, 2009 at 12:03:52AM -0400, Mike Frysinger wrote:
>The massive nommu update (8feae131) resulted in these warnings:
>ipc/shm.c: In function ‘sys_shmdt’:
>ipc/shm.c:974: warning: unused variable ‘size’
>ipc/shm.c:972: warning: unused variable ‘next’
>
>Signed-off-by: Mike Frysinger <vapier@...too.org>

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>


>---
> ipc/shm.c |    7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/ipc/shm.c b/ipc/shm.c
>index faa46da..4259716 100644
>--- a/ipc/shm.c
>+++ b/ipc/shm.c
>@@ -969,10 +969,13 @@ SYSCALL_DEFINE3(shmat, int, shmid, char __user *, shmaddr, int, shmflg)
> SYSCALL_DEFINE1(shmdt, char __user *, shmaddr)
> {
> 	struct mm_struct *mm = current->mm;
>-	struct vm_area_struct *vma, *next;
>+	struct vm_area_struct *vma;
> 	unsigned long addr = (unsigned long)shmaddr;
>-	loff_t size = 0;
> 	int retval = -EINVAL;
>+#ifdef CONFIG_MMU
>+	loff_t size = 0;
>+	struct vm_area_struct *next;
>+#endif
> 
> 	if (addr & ~PAGE_MASK)
> 		return retval;
>-- 
>1.6.3.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/